Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog to docs #484

Merged
merged 13 commits into from
Jul 15, 2021
Merged

Conversation

phil-scott-78
Copy link
Contributor

I want to checkout the output generated from the CI and make sure things don't get squirelly with github actions and playwright. But if that works this might just be ready.

I'm still not 100% pleased with the index page for the categories, but they still look ok there and aren't going to be very frequently traveled pages anyways.

* Upgrades doc project to .NET 6
* Adds Playwright
* Changes the console to a web project for Playwright
* Adds social card template
need to investigate whether or not the playwright bug is MacOS specific or not.
I think there might be some subtle threading issues. lots of extremely long waits trying to access shared resources. gonna run synchronously for now.
Moving the blog up the list a bit, and giving the order some gaps to make sliding in new sections a bit easier in the future.
@phil-scott-78
Copy link
Contributor Author

Cleaned up some CI errors that popped up then verified the artifact that the docs look good.

Might be some spelling mistake and the first post isn't exactly pulitzer award winning material, but I feel good about the tech side of things at least :-)

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but found one thing that might need to be fixed

.github/workflows/ci.yaml Show resolved Hide resolved
Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patriksvensson patriksvensson merged commit 223642b into spectreconsole:main Jul 15, 2021
@patriksvensson
Copy link
Contributor

Merged! 🎉

@phil-scott-78 phil-scott-78 deleted the add-blog-to-docs branch February 15, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants