-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog to docs #484
Add blog to docs #484
Conversation
* Upgrades doc project to .NET 6 * Adds Playwright * Changes the console to a web project for Playwright * Adds social card template
need to investigate whether or not the playwright bug is MacOS specific or not.
I think there might be some subtle threading issues. lots of extremely long waits trying to access shared resources. gonna run synchronously for now.
Moving the blog up the list a bit, and giving the order some gaps to make sliding in new sections a bit easier in the future.
Swap null check for default check
Cleaned up some CI errors that popped up then verified the artifact that the docs look good. Might be some spelling mistake and the first post isn't exactly pulitzer award winning material, but I feel good about the tech side of things at least :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but found one thing that might need to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Merged! 🎉 |
I want to checkout the output generated from the CI and make sure things don't get squirelly with github actions and playwright. But if that works this might just be ready.
I'm still not 100% pleased with the index page for the categories, but they still look ok there and aren't going to be very frequently traveled pages anyways.