Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlines in Selection #1345

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Outlines in Selection #1345

merged 6 commits into from
Jan 27, 2023

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Added stencil on-top outlines for selected objects.#1332

Changes:

  • Implemented a stencil prepass and a stencil mask pass. Currently only used for outlines

To-do before merge:

  • I went through all my test streams and the outlines seem to be working fine with the other existing features (filtering, sectioning, etc). However, some more testing would be good

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@didimitrie didimitrie merged commit 9299ee7 into main Jan 27, 2023
@didimitrie didimitrie deleted the alex/#1332-selection-style branch January 27, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants