Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): fixing double summary emails per week #1054

Merged
merged 16 commits into from
Oct 4, 2022

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Sep 29, 2022

No description provided.

@fabis94 fabis94 self-assigned this Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 88.77% // Head: 89.06% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (d2baeb3) compared to base (f48ee30).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   88.77%   89.06%   +0.28%     
==========================================
  Files         142      144       +2     
  Lines        4640     4671      +31     
  Branches      258      262       +4     
==========================================
+ Hits         4119     4160      +41     
+ Misses        413      404       -9     
+ Partials      108      107       -1     
Impacted Files Coverage Δ
packages/server/modules/activitystream/index.ts 95.65% <100.00%> (+20.65%) ⬆️
packages/server/modules/core/dbSchema.ts 100.00% <100.00%> (ø)
...server/modules/core/repositories/scheduledTasks.ts 100.00% <100.00%> (ø)
...ages/server/modules/core/services/taskScheduler.ts 100.00% <100.00%> (ø)
packages/server/modules/shared/utils/logger.ts 100.00% <100.00%> (ø)
.../server/modules/activitystream/services/summary.ts 100.00% <0.00%> (+5.88%) ⬆️
...erver/modules/activitystream/repositories/index.ts 81.81% <0.00%> (+18.18%) ⬆️
...kages/server/modules/shared/helpers/errorHelper.ts 55.55% <0.00%> (+22.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fabis94 fabis94 assigned gjedlicska and unassigned fabis94 Sep 29, 2022
@gjedlicska gjedlicska marked this pull request as ready for review October 4, 2022 12:40
@gjedlicska
Copy link
Contributor

currently this includes a cron trigger of 1000 seconds for weekly activity digests, this should be rolled back before release

@gjedlicska
Copy link
Contributor

fixes #1064

Copy link
Contributor Author

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjedlicska approved (can't approve my own PR)

@gjedlicska
Copy link
Contributor

don't worry, i'll approve it for you :D

gjedlicska
gjedlicska previously approved these changes Oct 4, 2022
@gjedlicska gjedlicska merged commit 1351b6b into main Oct 4, 2022
@gjedlicska gjedlicska deleted the gergo/cronJobGlobalLock branch October 4, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants