Cache bypass header now also prevents an already cached response from being returned #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #406
The previous implementation had a bug by which responsecache would return a previously cached response, even if the request had valid bypass headers.
I'm a bit concern that this refactor might cause a breaking change if someone is already using the
requestHasCacheBypassHeader
method from BaseCacheProfile, since I removed it. I think the current implementation is simpler and more clear, but I'm of course open to adding it back.