Rename DEBUG enum as Debug. #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a conflict with the commonly used DEBUG build macro. The names match the change made to https://github.com/LibreCAD/libdxfrw in commit 6c094ba.
|
If you are really interested in this area, I'd like to point you to Solvespace issue 326: This is also listed for the 4.0 milestone here: |
|
Ah.. thanks for the info., but I only had to do this fix so that I could build solvespace with another build system (which uses the DEBUG macro). I was not interested in the library itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a conflict with the commonly used DEBUG build macro.
The names match the change made to https://github.com/LibreCAD/libdxfrw in commit 6c094ba.