Variant Autocomplete: Allow passing select2 options #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
mamhoff
force-pushed
the
allow-other-variant-autocomplete-options
branch
2 times, most recently
from
4df93cb
to
c32c98e
Compare
This change allows users of the variant autocomplete to customize the
behavior of select2, rather that just discarding all the keys that are
not `searchParameters`.
We're using this for a custom controller in which we want to be able to
filter by variant, and be able to clear the selection.
So in that controller, we can do:
```js
const inputElement = document.getElementById('variantInput')
inputElement.variantAutocomplete({ allowClear: true })
```
mamhoff
force-pushed
the
allow-other-variant-autocomplete-options
branch
from
c32c98e
to
dce4abb
Compare
tvdeyen
approved these changes
Sep 25, 2024
backend/app/assets/javascripts/spree/backend/variant_autocomplete.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5861 +/- ##
==========================================
+ Coverage 89.23% 91.95% +2.72%
==========================================
Files 752 346 -406
Lines 17510 7658 -9852
==========================================
- Hits 15625 7042 -8583
+ Misses 1885 616 -1269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change allows users of the variant autocomplete to customize the behavior of select2, rather that just discarding all the keys that are not
searchParameters.We're using this for a custom controller in which we want to be able to filter by variant, and be able to clear the selection.
So in that controller, we can do:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: