Spree::Variant.in_stock: Only show distinct variants #5860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
tvdeyen
approved these changes
Sep 25, 2024
Without the `.distinct` added to this scope, it returns the same variant multiple times if there is stock in multiple stock locations.
mamhoff
force-pushed
the
distinct-in-stock-variants
branch
from
0a34edd
to
b2f8e4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5860 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 752 752
Lines 17510 17510
=======================================
Hits 15625 15625
Misses 1885 1885
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without the
.distinctadded to this scope, it returns the same variant multiple times if there is stock in multiple stock locations.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: