Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegations #559

Closed
wants to merge 8 commits into from
Closed

Add delegations #559

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7a274e
Use allow_blank in case of uniqueness to save an extra query when pre…
tanmay3011 Nov 28, 2015
10ea458
Use attr_reader to access instance variable in model instead of direc…
tanmay3011 Nov 28, 2015
fb7a278
Delegate firstname and lastname to bill_address instead of creating s…
tanmay3011 Nov 28, 2015
6165d31
Delegate #product to variant
tanmay3011 Nov 28, 2015
78b4498
Delegate #id to #order in spree customer_return
tanmay3011 Nov 28, 2015
92eb035
Delegate #name to #variant in spree stock_item
tanmay3011 Nov 28, 2015
21224ef
Delegate #code to shipment_method
tanmay3011 Nov 28, 2015
63be30b
Delegate #name to zoneable
tanmay3011 Nov 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delegate #code to shipment_method
  • Loading branch information
@tanmay3011
tanmay3011 committed Dec 2, 2015
commit 21224ef8f13dfe2b92a0b6f2baaaf4ee2561c74d
5 changes: 1 addition & 4 deletions core/app/models/spree/shipping_rate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class ShippingRate < Spree::Base

delegate :order, :currency, to: :shipment
delegate :name, to: :shipping_method
delegate :code, to: :shipping_method, prefix: true

def display_base_price
Spree::Money.new(cost, currency: currency)
Expand Down Expand Up @@ -46,10 +47,6 @@ def shipping_method
Spree::ShippingMethod.unscoped { super }
end

def shipping_method_code
shipping_method.code
end

def tax_rate
Spree::TaxRate.unscoped { super }
end
Expand Down