Update promotion_actions_create_quantity_adjustments in core/engine

[philbirt]

I saw this while working on something else. It looks like we have already defined app.config.spree.calculators.promotion_actions_create_item_adjustments a few lines above. I think it was probably a copy-paste gone awry.

[jhawthorn]

👍 Indeed looks like bad copypasta

[cbrunsdon]

yea, 👍 though what this code does is a bit of a mystery to me.

[philbirt]

@cbrunsdon i believe its supposed to set which calculators are available for the different types of promotion actions. Although that its been like this for awhile is kind of telling that it may be useless.

[cbrunsdon]

@philbirt yea, I always assumed lots/most of this was useless I just haven't had time to look into it. @adammathys might know as he has dealt with way more of the promo stuff than I have.

[adammathys]

Ugh! Definitely a bad copy/paste on my part. The reason this works is because the admin view just re-uses the item adjustments one.

I suppose having Spree::Promotion::Actions::CreateQuantityAdjustments.calculators return the correct thing might be useful. Maybe we should just update this to read:

app.config.spree.calculators.promotion_actions_create_quantity_adjustments =
  app.config.spree.calculators.promotion_actions_create_item_adjustments

Since that's technically the most correct answer. (Although it does mean the FlexRate calculator would become available for quantity adjustments. Which might work. I'm not certain.)