Allow stock transfer permissions to view stock transfers to/from from viewable stock locations.

[athal7]

When given the stock transfer display or stock transfer management
permissions, there is a dropdown in admin/stock locations to filter by
stock locations, which was filled by the ability to transfer_to or
transfer_from a stock location. This change allows people with the stock
transfer permission sets to use that feature of stock transfers without
having to also have the ability to transfer_to or transfer_from a stock
location.

[jordan-brough]

Looks good to me. One question: I'm not very familiar with the Stock Transfer stuff, but is StockTransferDisplay a strange name at all, since it gives you permission to "admin" StockTransfers and "transfer_to"/"transfer_from" StockLocations?

Not saying we need to change it, just wondering. What's the meaning of "Display" for us in general in our permissions stuff?

[athal7]

the 'admin' action is super confusing, and possibly needs a rename. all that 'admin' gives you access to is the top-level nav tab. different from 'manage', which is an alias to access on all actions.

[athal7]

ping @jhawthorn @gmacdougall

[gmacdougall]

I echo the comments that @jordan-brough had around being confused why StockTransferDisplay permissions need the ability to transfer_from and transfer_to.

[athal7]

yea the naming is a bit confusing, though I'm not sure a better one. Here is the code path:

https://github.com/solidusio/solidus/blob/master/backend/app/views/spree/admin/stock_transfers/index.html.erb#L25 ->
https://github.com/solidusio/solidus/blob/master/backend/app/controllers/spree/admin/stock_transfers_controller.rb#L104 ->
https://github.com/solidusio/solidus/blob/master/backend/app/controllers/spree/admin/stock_transfers_controller.rb#L146-L152

[jhawthorn]

I also agree that transfer_from and transfer_to doesn't make sense for the "display" permission. Seems to me that the controller, or at possibly the view is should be checking the display permission instead.

[athal7]

@jordan-brough @gmacdougall @jhawthorn updated, hopefully this is more what you had in mind

[jordan-brough]

nice. 👍

[jordan-brough]

Btw, do we need any kind of release note or anything around the renaming? (I really don't know, just asking)

[jhawthorn]

Great 👍 I think this is good to go.

[athal7]

@jordan-brough transfer_to and transfer_from were introduced in 1.1.0.pre https://github.com/athal7/solidus/commit/35e18b3cb68e484c4c7fba7bedd6e89b9a08ff01, so I don't think that is necessary