Remove some unnecessary admin JS #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 The more of these things we can remove now, the easier cleaning up the whole admin will become. |
|
👍 |
🎉 💯
This was being used to vertically align some checkboxes. We can do this using css instead.
This was being used to equalize the hight of all rows in a definition list. This was only desirable for adding additional whitespace to the sidebar additional-info lists. Instead I have given the sidebar lists a min-height of 3em and fixed the clear float.
Was being used for html5shiv, which we don't need anymore.
This looks fairly broken in both chrome and firefox. We would do better to fix these properly if we want responsive tables.
jhawthorn
force-pushed
the
remove_some_js
branch
from
a47e019
to
9732480
Compare
|
👍 |
|
👍 thanks for the cleanup @jhawthorn |
jhawthorn
added a commit
that referenced
this pull request
Nov 23, 2015
Remove some unnecessary admin JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove jquery.valign, which we used to vertically align checkbox fields. We can use flexbox for this instead (IE10+).
Remove
equalize.js, this was a ham fisted way to increase the height of sidebar<dl>items and fix an issue with floating. Replaced this with a min height for list items in the sidebar and a workingclear:for all<dl>.Removed Modernizr, which we were using as an html5shiv (needed for IE<9). We only support IE10+ and don't need this.
Removed responsive tables because it looked like:
cc @graygilmore