Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token-2022: [L-04] Comment that TransferCheckedWithFee works for all mints #6860

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

joncinque
Copy link
Contributor

Problem

According to the Certora audit:

A TransferCheckedWithFee succeeds even if the mint account is not extended with TransferFeeConfig if the instruction argument expected_fees is zero. This makes TransferChecked redundant since it can always be replaced by TransferCheckedWithFee.

Recommendation:
Either not allow TransferCheckedWithFee to succeed when fees are not enabled, or document that this is an expected and allowed behavior.

Solution

Comment that it is intended for TransferCheckedWithFee to work with any mint.

@joncinque joncinque requested a review from 2501babe June 17, 2024 17:26
@joncinque joncinque merged commit 8536f6f into solana-labs:master Jun 24, 2024
35 checks passed
@joncinque joncinque deleted the twfcomment branch June 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants