Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors properly in the extracted encoder #162

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Handle errors properly in the extracted encoder #162

merged 1 commit into from
Sep 21, 2023

Conversation

jerzywilczek
Copy link
Collaborator

No description provided.

wkozyra95
wkozyra95 approved these changes Sep 15, 2023
View reviewed changes
compositor_pipeline/src/pipeline/encoder.rs
]),
)
.map_err(|e| e.to_string())?;
let encoder = encoder.open_as_with(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, now you are going to be in a git blame for that :D

compositor_pipeline/src/pipeline.rs Outdated Show resolved Hide resolved
@jerzywilczek jerzywilczek mentioned this pull request Sep 18, 2023
Merged
@jerzywilczek jerzywilczek force-pushed the @jerzywilczek/extract-encoder-errors branch 2 times, most recently from 6fa63e6 to 3926fd3 Compare September 19, 2023 13:34
@jerzywilczek jerzywilczek force-pushed the @jerzywilczek/extract-encoder branch 2 times, most recently from 2190cec to f192c69 Compare September 21, 2023 11:42
Base automatically changed from @jerzywilczek/extract-encoder to master September 21, 2023 11:49
@jerzywilczek jerzywilczek force-pushed the @jerzywilczek/extract-encoder-errors branch from 3926fd3 to 269c7ea Compare September 21, 2023 13:11
@jerzywilczek jerzywilczek force-pushed the @jerzywilczek/extract-encoder-errors branch from 269c7ea to c79f5f9 Compare September 21, 2023 13:14
@jerzywilczek jerzywilczek merged commit 375b1ae into master Sep 21, 2023
1 check passed
@jerzywilczek jerzywilczek deleted the @jerzywilczek/extract-encoder-errors branch September 21, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkozyra95 wkozyra95 wkozyra95 approved these changes

@noituri noituri noituri approved these changes

@WojciechBarczynski WojciechBarczynski WojciechBarczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerzywilczek @wkozyra95 @noituri @WojciechBarczynski