Implement unregistering renderers #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
requested review from
noituri,
jerzywilczek and
WojciechBarczynski
WojciechBarczynski
approved these changes
Sep 9, 2023
Comment on lines
+16
to
+19
| pub struct UnregisterError { | ||
| item_type: &'static str, | ||
| renderer_id: RendererId, | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub struct UnregisterError { | |
| item_type: &'static str, | |
| renderer_id: RendererId, | |
| } | |
| pub struct UnregisterItemNotFoundError { | |
| item_type: &'static str, | |
| renderer_id: RendererId, | |
| } |
There are a lot of other unregister errors
There was a problem hiding this comment.
I would prefer to leave it like this for consistency with RegisterError.
Comment on lines
+69
to
+75
| match self.registry.remove(id) { | ||
| Some(_) => Ok(()), | ||
| None => Err(UnregisterError { | ||
| item_type: self.registry_type.registry_item_name(), | ||
| renderer_id: id.clone(), | ||
| }), | ||
| } |
There was a problem hiding this comment.
ok_or maps None to Err, but here I need both map None to Err and Some(value) to Ok(())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56