Pbar

[kylon]

progress bar tested on linux and windows 10 (cmd and PS)

[lukaarma]

I would leave the message that tell the user that there were no errors...or make it behind verbose

Personally I like to know when a program like this runs successfully

[kylon]

which message?

[lukaarma]

The one you removed in the last commit

[kylon]

ok, you can't print a success message when exit code is 0 because exit code could 0 when the program dies for other reasons, so we don't know what happened, but we know we should not tell the user everything is ok.

[lukaarma]

I'm quite sure that if the program dies for any reason other than returning at the end of the execution the code will not be 0 @snobu, your opinion on the exit message question?

[snobu]

I'll merge this as it is for now and we can tweak it as we go.
Exit 0 is usually a good thing but as with everything, it depends. ffmpeg may consider downloading the video track without audio a success... We probably need some checks at the very end before we have the confidence to say everything went alright.

[kylon]

I'm quite sure that if the program dies for any reason other than returning at the end of the execution the code will not be 0 @snobu, your opinion on the exit message question?

signals can stop the execution and return 0 but it is not a success

[snobu]

Yup, here's a CTRL-C in Node and PowerShell reporting back a happy exit 0.

C:\destreamer [tokencache ≡]> node
Welcome to Node.js v13.11.0.
Type ".help" for more information.
>
(To exit, press ^C again or ^D or type .exit)
>
C:\destreamer>echo $?
True

[snobu]

Note to everyone involved, don't do a pull, start a fresh clone in a new folder since the structure has now dramatically changed to src/ and build/. I believe this to be the right move at this point as it was getting out of hand with those files sprayed out everywhere.

[snobu]

@kylon,

Where is this coming from?

C:\destreamer [tokencache ≡]> node build/destreamer.js --videoUrls https://xxxxx.microsoftstream.com/video/e3f0-xxx-xxxx-xxxx-xxx 

internal/modules/cjs/loader.js:979
  throw err;
  ^

Error: Cannot find module 'C:\destreamer\build\destreamer.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:976:15)
    at Function.Module._load (internal/modules/cjs/loader.js:859:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Is this expected or i'm launching it all wrong?

[snobu]

Ah found it, it's building in build/src/*.js instead of build/*.js.
Is this what you wanted?

[snobu]

So the progress works nicely but it never exists, just hangs like this:

The file is there in the target output dir and is completed (muxed).

I believe it hangs awaiting on the progress bar.
If i add a manual exit(0) it does exit.

            .on('end', () => {
                console.log(colors.green(`\nDownload finished: ${outputPath}`));
                process.exit(0);
            });

LATER EDIT: We could piggyback on .end() and pull the bar to 100% so it exists cleanly - tested, works. I'll let @kylon decide on the final implementation.

            .on('end', () => {
                pbar.update(100);
                console.log(colors.green(`\nDownload finished: ${outputPath}`));
            });

[kylon]

the progress bar should "kill" itself when the progress is 100% but here it is not, so it is waiting for the next update

i would like to know why it s not 100, what is the currentChunk value and duration value (total chunks)

[snobu]

Looks like it's an off by one problem as it always reaches 97%. Just print the chunks as it goes along maybe it reveals the flaw.

[kylon]

my videos reach 100, i ll try more videos or is your video public?

my ideas are:
1 wrong chunks calculation for some reasons
2 ffmpeg skips progress event and goes to end for the last chunk

if the latter is the case, yeah we should move the bar ourself, otherwise it is probably better to see what happen to prevent future issues

[snobu]

For some videos it goes all the way to 100% but still doesn't exit.

with currentChunks -

[kylon]

try this, it seems ffmpeg goes to end for the last chunk

add this before ffmepg()
let pre = 0;

 on('progress', progress => {
                 const currentChunks = ffmpegTimemarkToChunk(progress.timemark);
                const cc = currentChunks - pre;

                 pbar.increment(cc, {
                     speed: progress.currentKbps
                 });
                 pre = currentChunks
             })

[snobu]

The question is, how reliable is the chunk counter, if we just do pbar.update(100) inside .on('end..
we have a much better chance to avoid off-by-a-chunk hangs that we may not be able to handle now since we haven't seen them. They may not exist but that's just speculation at this point.

I'm more worried about what ffmpeg is feeding us than what we do in our method. There are dozens, dozens of slightly different builds of ffmpeg out there people use.

[kylon]

yeah, i m fixing the video download and progress bar
i m using both, i found that the code above is more precise then update() and update(100) just to be sure when done

[kylon]

I'm more worried about what ffmpeg is feeding us than what we do in our method. There are dozens, dozens of slightly different builds of ffmpeg out there people use.

what you mean?
we are using fluent, the worst case is ffmpeg changes and fluent can no longer give us the timemark

[lukaarma]

I think that what @snobu meant is that being many different version of ffmpeg they might elaborate chunks slightly differently or they might feed sliglty different data into fluent-ffmpeg so we don't want to rely only on that and use that update(100)