Add intEnum validation to NodeValidationVisitor #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximk000
force-pushed
the
intenumplugin-nodevalidationvisitor
branch
from
6e4f61c
to
b30e759
Compare
sugmanue
reviewed
Jul 25, 2024
smithy-model/src/main/java/software/amazon/smithy/model/validation/node/IntEnumPlugin.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Manuel Sugawara <[email protected]>
sugmanue
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Adds a new plugin to validate intEnums in NodeValidationVisitor. Previously you could provide values outside of the allowed set without failing validation. IntEnum Shapes also qualify as Integer Shapes, so they will pass through the same validation as Integer Shapes in
validateNaturalNumber()to make sure floats aren't provided.Testing
Added test cases:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.