Add progress tracker and message for CLI while cloning a template #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
reviewed
Jul 28, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/ProgressTracker.java
Outdated
Show resolved
Hide resolved
hpmellema
force-pushed
the
add-copying-message
branch
from
4251ac5
to
209cd47
Compare
mtdowling
requested changes
Jul 31, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/ProgressStyle.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
This works, thanks. I think we can improve the style/updater APIs in the future to improve them a bit more (e.g., one idea is to make the update value a generic parameter of the style and update class, then allow update messages to be sent to the updater which then sends it to the styler, allowing progress bars, messages, etc).
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
…ithy-lang#1888) Adds a progress tracker for long running CLI tasks. The progress tracker currently supports a simple repeated dots pattern to indicate execution of a long running task. The progress tracker can be extended in the future to support progress bars and additional loading messages.
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
…ithy-lang#1888) Adds a progress tracker for long running CLI tasks. The progress tracker currently supports a simple repeated dots pattern to indicate execution of a long running task. The progress tracker can be extended in the future to support progress bars and additional loading messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a progress tracker class that can be used to execute a progress tracker for the CLI while waiting for a set of commands to execute. This PR adds the progress tracker to cloning of templates in the init command as that action can take multiple seconds to complete.
Additional loading bars and progress tracker styles could be added in the future.
Example Execution gif:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.