Collection of fixes replaces #42, #56, #63 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use DecodeWords instead to test more variants
Swap from {Expected, Encoded} to {Encoded, Expected} (Different encoded variants can give the same result)
Add data for split variants, and also variants that have non encoded data mixed in.
…ng because of lineending miss on git checkout.
…part/alternative is defined and we have a name (filename) This fixes the new MessageWithMultipartMixedAttachment Test But causes MessageWithMultipleParts to fail, that can easily be fixed by checking for the 2 Attachments instead of 3 AlternateViews
…ad of 3 AlternateViews
|
Sorry for this monster pull, but I at least tried to keep each commit informational and easy to understand. In regards to #49 / #63 This pull only have changes that makes some primary handling. But will revisit #48. #56 is included here more or less as is with some cleanup. That mostly fixes #55 for me. About #42: Skipped some changes done in regards to #37 but did other handling in d892d32 instead. |
|
merged. great job, will check it out later today. |
|
OK the tests all work fine, are there still any issues with this or can we merge this into master? |
|
test looks good to me 👍 |
|
OK merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to show issues.
Fixes for those issues.