Py_TYPE() has already dereferenced self before the NULL check. Moved …

…Py_TYPE() after the check for self == NULL
skrah · Sep 10, 2012 · f03572d · f03572d
2 parents 1b5c76a + 949f331
commit f03572d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Objects/classobject.c b/Objects/classobject.c
@@ -219,14 +219,15 @@ method_repr(PyMethodObject *a)
 {
     PyObject *self = a->im_self;
     PyObject *func = a->im_func;
-    PyObject *klass = (PyObject*)Py_TYPE(self);
+    PyObject *klass;
     PyObject *funcname = NULL ,*klassname = NULL, *result = NULL;
     char *defname = "?";
 
     if (self == NULL) {
         PyErr_BadInternalCall();
         return NULL;
     }
+    klass = (PyObject*)Py_TYPE(self);
 
     funcname = _PyObject_GetAttrId(func, &PyId___name__);
     if (funcname == NULL) {