Fix the return value of set_discard (issue python#10519)

skrah · Oct 30, 2011 · e0aa803 · e0aa803
1 parent 5acc27e
commit e0aa803
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Objects/setobject.c b/Objects/setobject.c
@@ -1942,9 +1942,10 @@ set_discard(PySetObject *so, PyObject *key)
         tmpkey = make_new_set(&PyFrozenSet_Type, key);
         if (tmpkey == NULL)
             return NULL;
-        result = set_discard_key(so, tmpkey);
+        rv = set_discard_key(so, tmpkey);
         Py_DECREF(tmpkey);
-        return result;
+        if (rv == -1)
+            return NULL;
     }
     Py_RETURN_NONE;
 }