Skip to content

Commit

Permalink
Issue python#4555: All exported C symbols are now prefixed with eithe…
Browse files Browse the repository at this point in the history
…r "Py" or "_Py".

("make smelly" now clean)
  • Loading branch information
pitrou committed Oct 12, 2013
1 parent 409b538 commit d01d396
Show file tree
Hide file tree
Showing 6 changed files with 89 additions and 86 deletions.
4 changes: 2 additions & 2 deletions Include/asdl.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ typedef struct {
int elements[1];
} asdl_int_seq;

asdl_seq *asdl_seq_new(Py_ssize_t size, PyArena *arena);
asdl_int_seq *asdl_int_seq_new(Py_ssize_t size, PyArena *arena);
asdl_seq *_Py_asdl_seq_new(Py_ssize_t size, PyArena *arena);
asdl_int_seq *_Py_asdl_int_seq_new(Py_ssize_t size, PyArena *arena);

#define asdl_seq_GET(S, I) (S)->elements[(I)]
#define asdl_seq_LEN(S) ((S) == NULL ? 0 : (S)->size)
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ Projected release date: 2013-10-20
Core and Builtins
-----------------

- Issue #4555: All exported C symbols are now prefixed with either
"Py" or "_Py".

- Issue #19219: Speed up marshal.loads(), and make pyc files slightly
(5% to 10%) smaller.

Expand Down
4 changes: 2 additions & 2 deletions Parser/asdl_c.py
Original file line number Diff line number Diff line change
Expand Up @@ -519,9 +519,9 @@ def visitField(self, field, name, sum=None, prod=None, depth=0):
self.emit("}", depth+1)
self.emit("len = PyList_GET_SIZE(tmp);", depth+1)
if self.isSimpleType(field):
self.emit("%s = asdl_int_seq_new(len, arena);" % field.name, depth+1)
self.emit("%s = _Py_asdl_int_seq_new(len, arena);" % field.name, depth+1)
else:
self.emit("%s = asdl_seq_new(len, arena);" % field.name, depth+1)
self.emit("%s = _Py_asdl_seq_new(len, arena);" % field.name, depth+1)
self.emit("if (%s == NULL) goto failed;" % field.name, depth+1)
self.emit("for (i = 0; i < len; i++) {", depth+1)
self.emit("%s value;" % ctype, depth+2)
Expand Down
Loading

0 comments on commit d01d396

Please sign in to comment.