Skip to content

Commit

Permalink
remove configure check for memmove (python#3716)
Browse files Browse the repository at this point in the history
Python requires C implementations provide memmove, so we shouldn't need to check for it. The only place using this configure check was expat, where we can simply always define HAVE_MEMMOVE.
  • Loading branch information
benjaminp authored Sep 24, 2017
1 parent 5b9299d commit b1d1c42
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 19 deletions.
2 changes: 2 additions & 0 deletions Modules/expat/expat_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#define BYTEORDER 1234
#endif

#define HAVE_MEMMOVE 1

#define XML_NS 1
#define XML_DTD 1
#define XML_CONTEXT_BYTES 1024
Expand Down
13 changes: 0 additions & 13 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -12253,19 +12253,6 @@ fi
done


# Stuff for expat.
for ac_func in memmove
do :
ac_fn_c_check_func "$LINENO" "memmove" "ac_cv_func_memmove"
if test "x$ac_cv_func_memmove" = xyes; then :
cat >>confdefs.h <<_ACEOF
#define HAVE_MEMMOVE 1
_ACEOF

fi
done


# check for long file support functions
for ac_func in fseek64 fseeko fstatvfs ftell64 ftello statvfs
do :
Expand Down
3 changes: 0 additions & 3 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -3684,9 +3684,6 @@ AC_CHECK_FUNCS(forkpty,,
)
)

# Stuff for expat.
AC_CHECK_FUNCS(memmove)

# check for long file support functions
AC_CHECK_FUNCS(fseek64 fseeko fstatvfs ftell64 ftello statvfs)

Expand Down
3 changes: 0 additions & 3 deletions pyconfig.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -601,9 +601,6 @@
/* Define to 1 if you have the `mbrtowc' function. */
#undef HAVE_MBRTOWC

/* Define to 1 if you have the `memmove' function. */
#undef HAVE_MEMMOVE

/* Define to 1 if you have the <memory.h> header file. */
#undef HAVE_MEMORY_H

Expand Down

0 comments on commit b1d1c42

Please sign in to comment.