Issue python#13058: ossaudiodev: fix a file descriptor leak on error.…

… Patch by Thomas Jarosch.
skrah · Sep 29, 2011 · 9624a76 · 9624a76
2 parents a0702ab + 5a4a109
commit 9624a76
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -463,6 +463,7 @@ Bertrand Janin
 Geert Jansen
 Jack Jansen
 Bill Janssen
+Thomas Jarosch
 Julien Jehannet
 Drew Jenkins
 Flemming Kjær Jensen

diff --git a/Misc/NEWS b/Misc/NEWS
@@ -1298,6 +1298,9 @@ Tools/Demos
 Extension Modules
 -----------------
 
+- Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by
+  Thomas Jarosch.
+
 - Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype.
   Thanks to Suman Saha for finding the bug and providing a patch.
 

diff --git a/Modules/ossaudiodev.c b/Modules/ossaudiodev.c
@@ -129,6 +129,7 @@ newossobject(PyObject *arg)
     }
 
     if (ioctl(fd, SNDCTL_DSP_GETFMTS, &afmts) == -1) {
+        close(fd);
         PyErr_SetFromErrnoWithFilename(PyExc_IOError, devicename);
         return NULL;
     }