Skip to content

Commit

Permalink
Access checks now work, at least for instance data (not for methods
Browse files Browse the repository at this point in the history
yet).  The class is now passed to eval_code and stored in the current
frame.  It is also stored in instance method objects.  An "unbound"
instance method is now returned when a function is retrieved through
"classname.funcname", which when called passes the class to eval_code.
  • Loading branch information
gvanrossum committed May 20, 1993
1 parent 2583165 commit 81daa32
Show file tree
Hide file tree
Showing 14 changed files with 655 additions and 150 deletions.
54 changes: 54 additions & 0 deletions Include/accessobject.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/***********************************************************
Copyright 1991, 1992, 1993 by Stichting Mathematisch Centrum,
Amsterdam, The Netherlands.
All Rights Reserved
Permission to use, copy, modify, and distribute this software and its
documentation for any purpose and without fee is hereby granted,
provided that the above copyright notice appear in all copies and that
both that copyright notice and this permission notice appear in
supporting documentation, and that the names of Stichting Mathematisch
Centrum or CWI not be used in advertising or publicity pertaining to
distribution of the software without specific, written prior permission.
STICHTING MATHEMATISCH CENTRUM DISCLAIMS ALL WARRANTIES WITH REGARD TO
THIS SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS, IN NO EVENT SHALL STICHTING MATHEMATISCH CENTRUM BE LIABLE
FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
******************************************************************/

/* Access object interface */

/* Access mode bits (note similarity with UNIX permissions) */
#define AC_R 0444
#define AC_W 0222

#define AC_PRIVATE 0700
#define AC_R_PRIVATE 0400
#define AC_W_PRIVATE 0200

#define AC_PROTECTED 0070
#define AC_R_PROTECTED 0040
#define AC_W_PROTECTED 0020

#define AC_PUBLIC 0007
#define AC_R_PUBLIC 0004
#define AC_W_PUBLIC 0002

extern typeobject Accesstype;

#define is_accessobject(v) ((v)->ob_type == &Accesstype)

object *newaccessobject PROTO((object *, object *, typeobject *, int));
object *getaccessvalue PROTO((object *, object *));
int setaccessvalue PROTO((object *, object *, object *));

void setaccessowner PROTO((object *, object *));
object *cloneaccessobject PROTO((object *));

extern typeobject Anynumbertype, Anysequencetype, Anymappingtype;
1 change: 1 addition & 0 deletions Include/ceval.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ object *call_object PROTO((object *, object *));

object *getglobals PROTO((void));
object *getlocals PROTO((void));
object *getclass PROTO((void));
void mergelocals PROTO((void));

void printtraceback PROTO((object *));
Expand Down
12 changes: 11 additions & 1 deletion Include/classobject.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ It should be possible to use other object types as base classes,
but currently it isn't. We'll see if we can fix that later, sigh...
*/

typedef struct {
OB_HEAD
object *cl_bases; /* A tuple of class objects */
object *cl_dict; /* A dictionary */
object *cl_name; /* A string */
} classobject;

extern typeobject Classtype, Instancetype, Instancemethodtype;

#define is_classobject(op) ((op)->ob_type == &Classtype)
Expand All @@ -38,9 +45,12 @@ extern typeobject Classtype, Instancetype, Instancemethodtype;

extern object *newclassobject PROTO((object *, object *, object *));
extern object *newinstanceobject PROTO((object *, object *));
extern object *newinstancemethodobject PROTO((object *, object *));
extern object *newinstancemethodobject PROTO((object *, object *, object *));

extern object *instancemethodgetfunc PROTO((object *));
extern object *instancemethodgetself PROTO((object *));
extern object *instancemethodgetclass PROTO((object *));

extern object *instance_convert PROTO((object *, char *));

extern int issubclass PROTO((object *, object *));
3 changes: 2 additions & 1 deletion Include/eval.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

/* Interface to execute compiled code */

object *eval_code PROTO((codeobject *, object *, object *, object *));
object *eval_code
PROTO((codeobject *, object *, object *, object *, object *));
3 changes: 2 additions & 1 deletion Include/frameobject.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ typedef struct _frame {
codeobject *f_code; /* code segment */
object *f_globals; /* global symbol table (dictobject) */
object *f_locals; /* local symbol table (dictobject) */
object *f_class; /* class context (classobject or NULL) */
object *f_fastlocals; /* fast local variables (listobject) */
object *f_localmap; /* local variable names (dictobject) */
object **f_valuestack; /* malloc'ed array */
Expand All @@ -55,7 +56,7 @@ extern typeobject Frametype;
#define is_frameobject(op) ((op)->ob_type == &Frametype)

frameobject * newframeobject PROTO(
(frameobject *, codeobject *, object *, object *, int, int));
(frameobject *, codeobject *, object *, object *, object *, int, int));


/* The rest of the interface is specific for frame objects */
Expand Down
Loading

0 comments on commit 81daa32

Please sign in to comment.