Skip to content

Commit

Permalink
Get rid of xreadlines() (methods).
Browse files Browse the repository at this point in the history
  • Loading branch information
nnorwitz committed Mar 17, 2006
1 parent 7c30724 commit 7096760
Show file tree
Hide file tree
Showing 11 changed files with 9 additions and 47 deletions.
9 changes: 0 additions & 9 deletions Doc/lib/libbz2.tex
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,6 @@ \subsection{(De)compression of files}
is an approximate bound on the total number of bytes in the lines returned.
\end{methoddesc}

\begin{methoddesc}[BZ2File]{xreadlines}{}
For backward compatibility. \class{BZ2File} objects now include the
performance optimizations previously implemented in the
\module{xreadlines} module.
\deprecated{2.3}{This exists only for compatibility with the method by
this name on \class{file} objects, which is
deprecated. Use \code{for line in file} instead.}
\end{methoddesc}

\begin{methoddesc}[BZ2File]{seek}{offset\optional{, whence}}
Move to new file position. Argument \var{offset} is a byte count. Optional
argument \var{whence} defaults to \code{0} (offset from start of file,
Expand Down
6 changes: 0 additions & 6 deletions Doc/lib/libstdtypes.tex
Original file line number Diff line number Diff line change
Expand Up @@ -1583,12 +1583,6 @@ \subsection{File Objects
implemented, or cannot be implemented efficiently.
\end{methoddesc}

\begin{methoddesc}[file]{xreadlines}{}
This method returns the same thing as \code{iter(f)}.
\versionadded{2.1}
\deprecated{2.3}{Use \samp{for \var{line} in \var{file}} instead.}
\end{methoddesc}

\begin{methoddesc}[file]{seek}{offset\optional{, whence}}
Set the file's current position, like \code{stdio}'s \cfunction{fseek()}.
The \var{whence} argument is optional and defaults to \code{0}
Expand Down
2 changes: 1 addition & 1 deletion Doc/tools/undoc_symbols.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

def findnames(file, prefixes=()):
names = {}
for line in file.xreadlines():
for line in file:
if line[0] == '!':
continue
fields = line.split()
Expand Down
2 changes: 1 addition & 1 deletion Lib/rexec.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
class FileBase:

ok_file_methods = ('fileno', 'flush', 'isatty', 'read', 'readline',
'readlines', 'seek', 'tell', 'write', 'writelines', 'xreadlines',
'readlines', 'seek', 'tell', 'write', 'writelines',
'__iter__')


Expand Down
10 changes: 1 addition & 9 deletions Lib/test/test_bz2.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ def testIterator(self):
self.assertEqual(list(iter(bz2f)), sio.readlines())
bz2f.close()

def testXReadLines(self):
# "Test BZ2File.xreadlines()"
self.createTempFile()
bz2f = BZ2File(self.filename)
sio = StringIO(self.TEXT)
self.assertEqual(list(bz2f.xreadlines()), sio.readlines())
bz2f.close()

def testUniversalNewlinesLF(self):
# "Test BZ2File.read() with universal newlines (\\n)"
self.createTempFile()
Expand Down Expand Up @@ -256,7 +248,7 @@ def testBug1191043(self):
bz2f.close()
self.assertEqual(lines, ['Test'])
bz2f = BZ2File(self.filename)
xlines = list(bz2f.xreadlines())
xlines = list(bz2f.readlines())
bz2f.close()
self.assertEqual(lines, ['Test'])

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_decimal.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def eval_file(self, file):
if skip_expected:
raise TestSkipped
return
for line in open(file).xreadlines():
for line in open(file):
line = line.replace('\r\n', '').replace('\n', '')
#print line
try:
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class NonString: pass

methods = ['fileno', 'flush', 'isatty', 'next', 'read', 'readinto',
'readline', 'readlines', 'seek', 'tell', 'truncate', 'write',
'xreadlines', '__iter__']
'__iter__']
if sys.platform.startswith('atheos'):
methods.remove('truncate')

Expand Down
2 changes: 1 addition & 1 deletion Misc/python.man
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ expressed in spaces. Issue an error when the option is given twice.
.B \-u
Force stdin, stdout and stderr to be totally unbuffered. On systems
where it matters, also put stdin, stdout and stderr in binary mode.
Note that there is internal buffering in xreadlines(), readlines() and
Note that there is internal buffering in readlines() and
file-object iterators ("for line in sys.stdin") which is not
influenced by this option. To work around this, you will want to use
"sys.stdin.readline()" inside a "while 1:" loop.
Expand Down
8 changes: 0 additions & 8 deletions Modules/bz2module.c
Original file line number Diff line number Diff line change
Expand Up @@ -778,13 +778,6 @@ BZ2File_readlines(BZ2FileObject *self, PyObject *args)
return list;
}

PyDoc_STRVAR(BZ2File_xreadlines__doc__,
"xreadlines() -> self\n\
\n\
For backward compatibility. BZ2File objects now include the performance\n\
optimizations previously implemented in the xreadlines module.\n\
");

PyDoc_STRVAR(BZ2File_write__doc__,
"write(data) -> None\n\
\n\
Expand Down Expand Up @@ -1183,7 +1176,6 @@ static PyMethodDef BZ2File_methods[] = {
{"read", (PyCFunction)BZ2File_read, METH_VARARGS, BZ2File_read__doc__},
{"readline", (PyCFunction)BZ2File_readline, METH_VARARGS, BZ2File_readline__doc__},
{"readlines", (PyCFunction)BZ2File_readlines, METH_VARARGS, BZ2File_readlines__doc__},
{"xreadlines", (PyCFunction)BZ2File_getiter, METH_VARARGS, BZ2File_xreadlines__doc__},
{"write", (PyCFunction)BZ2File_write, METH_VARARGS, BZ2File_write__doc__},
{"writelines", (PyCFunction)BZ2File_writelines, METH_O, BZ2File_writelines__doc__},
{"seek", (PyCFunction)BZ2File_seek, METH_VARARGS, BZ2File_seek__doc__},
Expand Down
7 changes: 0 additions & 7 deletions Objects/fileobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -1675,12 +1675,6 @@ PyDoc_STRVAR(readlines_doc,
"The optional size argument, if given, is an approximate bound on the\n"
"total number of bytes in the lines returned.");

PyDoc_STRVAR(xreadlines_doc,
"xreadlines() -> returns self.\n"
"\n"
"For backward compatibility. File objects now include the performance\n"
"optimizations previously implemented in the xreadlines module.");

PyDoc_STRVAR(writelines_doc,
"writelines(sequence_of_strings) -> None. Write the strings to the file.\n"
"\n"
Expand Down Expand Up @@ -1719,7 +1713,6 @@ static PyMethodDef file_methods[] = {
{"tell", (PyCFunction)file_tell, METH_NOARGS, tell_doc},
{"readinto", (PyCFunction)file_readinto, METH_VARARGS, readinto_doc},
{"readlines", (PyCFunction)file_readlines,METH_VARARGS, readlines_doc},
{"xreadlines",(PyCFunction)file_self, METH_NOARGS, xreadlines_doc},
{"writelines",(PyCFunction)file_writelines, METH_O, writelines_doc},
{"flush", (PyCFunction)file_flush, METH_NOARGS, flush_doc},
{"close", (PyCFunction)file_close, METH_NOARGS, close_doc},
Expand Down
6 changes: 3 additions & 3 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,9 @@ Cray T3E: Mark Hadfield ([email protected]) writes:

_codecs, _locale, _socket, _symtable, _testcapi, _weakref
array, binascii, cmath, cPickle, crypt, cStringIO, dbm
errno, fcntl, grp, math, md5, operator, parser, pcre, pwd
regex, rotor, select, struct, strop, syslog, termios
time, timing, xreadlines
errno, fcntl, grp, math, md5, operator, parser, pwd
rotor, select, struct, strop, syslog, termios,
time, timing

4) Once the python executable and library have been built, make
will execute setup.py, which will attempt to build remaining
Expand Down

0 comments on commit 7096760

Please sign in to comment.