Issue python#6314: logging.basicConfig() performs extra checks on the…

… "level" argument.
skrah · Jun 21, 2009 · 0f6eac2 · 0f6eac2
1 parent 2a998fa
commit 0f6eac2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
@@ -1396,6 +1396,10 @@ def basicConfig(**kwargs):
         root.addHandler(hdlr)
         level = kwargs.get("level")
         if level is not None:
+            if str(level) == level: # If a string was passed, do more checks
+                if level not in _levelNames:
+                    raise ValueError("Unknown level: %r" % level)
+                level = _levelNames[level]
             root.setLevel(level)
 
 #---------------------------------------------------------------------------

diff --git a/Misc/NEWS b/Misc/NEWS
@@ -15,12 +15,15 @@ Core and Builtins
 Library
 -------
 
+- Issue #6314: logging.basicConfig() performs extra checks on the "level"
+  argument.
+
 - Issue #6274: Fixed possible file descriptors leak in subprocess.py
 
 - Accessing io.StringIO.buffer now raises an AttributeError instead of
   io.UnsupportedOperation.
 
-- Issue #6271: mmap tried to close invalid file handle (-1) when annonymous.
+- Issue #6271: mmap tried to close invalid file handle (-1) when anonymous.
   (On Unix)