Skip to content

Commit

Permalink
Merge UNPACK_LIST and UNPACK_TUPLE into a single UNPACK_SEQUENCE, sin…
Browse files Browse the repository at this point in the history
…ce they

did the same anyway.

I'm not sure what to do with Tools/compiler/compiler/* -- that isn't part of
distutils, is it ? Should it try to be compatible with old bytecode version ?
  • Loading branch information
Yhg1s committed Aug 11, 2000
1 parent a8d7341 commit 0be5aab
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 29 deletions.
8 changes: 4 additions & 4 deletions Doc/lib/libdis.tex
Original file line number Diff line number Diff line change
Expand Up @@ -337,14 +337,14 @@ \subsection{Python Byte Code Instructions}
\member{co_names} attribute of the code object.
\end{opcodedesc}

\begin{opcodedesc}{UNPACK_TUPLE}{count}
\begin{opcodedesc}{UNPACK_SEQUENCE}{count}
Unpacks TOS into \var{count} individual values, which are put onto
the stack right-to-left.
\end{opcodedesc}

\begin{opcodedesc}{UNPACK_LIST}{count}
Unpacks TOS into \var{count} individual values.
\end{opcodedesc}
%\begin{opcodedesc}{UNPACK_LIST}{count}
%This opcode is obsolete.
%\end{opcodedesc}

%\begin{opcodedesc}{UNPACK_ARG}{count}
%This opcode is obsolete.
Expand Down
4 changes: 2 additions & 2 deletions Include/opcode.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ redistribution of this file, and for a DISCLAIMER OF ALL WARRANTIES.

#define STORE_NAME 90 /* Index in name list */
#define DELETE_NAME 91 /* "" */
#define UNPACK_TUPLE 92 /* Number of tuple items */
#define UNPACK_LIST 93 /* Number of list items */
#define UNPACK_SEQUENCE 92 /* Number of sequence items */

#define STORE_ATTR 95 /* Index in name list */
#define DELETE_ATTR 96 /* "" */
#define STORE_GLOBAL 97 /* "" */
Expand Down
4 changes: 2 additions & 2 deletions Lib/dis.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ def jabs_op(name, op):

name_op('STORE_NAME', 90) # Index in name list
name_op('DELETE_NAME', 91) # ""
def_op('UNPACK_TUPLE', 92) # Number of tuple items
def_op('UNPACK_LIST', 93) # Number of list items
def_op('UNPACK_SEQUENCE', 92) # Number of tuple items

name_op('STORE_ATTR', 95) # Index in name list
name_op('DELETE_ATTR', 96) # ""
name_op('STORE_GLOBAL', 97) # ""
Expand Down
3 changes: 1 addition & 2 deletions Python/ceval.c
Original file line number Diff line number Diff line change
Expand Up @@ -1165,8 +1165,7 @@ eval_code2(PyCodeObject *co, PyObject *globals, PyObject *locals,
default: switch (opcode) {
#endif

case UNPACK_TUPLE:
case UNPACK_LIST:
case UNPACK_SEQUENCE:
v = POP();
if (PyTuple_Check(v)) {
if (PyTuple_Size(v) != oparg) {
Expand Down
23 changes: 5 additions & 18 deletions Python/compile.c
Original file line number Diff line number Diff line change
Expand Up @@ -1729,27 +1729,14 @@ com_assign_trailer(struct compiling *c, node *n, int assigning)
}

static void
com_assign_tuple(struct compiling *c, node *n, int assigning)
com_assign_sequence(struct compiling *c, node *n, int assigning)
{
int i;
if (TYPE(n) != testlist)
REQ(n, exprlist);
if (assigning) {
i = (NCH(n)+1)/2;
com_addoparg(c, UNPACK_TUPLE, i);
com_push(c, i-1);
}
for (i = 0; i < NCH(n); i += 2)
com_assign(c, CHILD(n, i), assigning);
}

static void
com_assign_list(struct compiling *c, node *n, int assigning)
{
int i;
if (assigning) {
i = (NCH(n)+1)/2;
com_addoparg(c, UNPACK_LIST, i);
com_addoparg(c, UNPACK_SEQUENCE, i);
com_push(c, i-1);
}
for (i = 0; i < NCH(n); i += 2)
Expand All @@ -1775,7 +1762,7 @@ com_assign(struct compiling *c, node *n, int assigning)
case exprlist:
case testlist:
if (NCH(n) > 1) {
com_assign_tuple(c, n, assigning);
com_assign_sequence(c, n, assigning);
return;
}
n = CHILD(n, 0);
Expand Down Expand Up @@ -1843,7 +1830,7 @@ com_assign(struct compiling *c, node *n, int assigning)
"can't assign to []");
return;
}
com_assign_list(c, n, assigning);
com_assign_sequence(c, n, assigning);
return;
case NAME:
com_assign_name(c, CHILD(n, 0), assigning);
Expand Down Expand Up @@ -2869,7 +2856,7 @@ com_fplist(struct compiling *c, node *n)
}
else {
int i = (NCH(n)+1)/2;
com_addoparg(c, UNPACK_TUPLE, i);
com_addoparg(c, UNPACK_SEQUENCE, i);
com_push(c, i-1);
for (i = 0; i < NCH(n); i += 2)
com_fpdef(c, CHILD(n, i));
Expand Down
2 changes: 1 addition & 1 deletion Python/import.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ extern time_t PyOS_GetLastModificationTime(char *, FILE *);
/* XXX Perhaps the magic number should be frozen and a version field
added to the .pyc file header? */
/* New way to come up with the magic number: (YEAR-1995), MONTH, DAY */
#define MAGIC (50428 | ((long)'\r'<<16) | ((long)'\n'<<24))
#define MAGIC (50811 | ((long)'\r'<<16) | ((long)'\n'<<24))

/* Magic word as global; note that _PyImport_Init() can change the
value of this global to accommodate for alterations of how the
Expand Down

0 comments on commit 0be5aab

Please sign in to comment.