Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to execute in NeoVim :terminal #73

Merged
merged 4 commits into from
Sep 16, 2016

Conversation

brodock
Copy link
Contributor

@brodock brodock commented Sep 9, 2016

NeoVim has it's own terminal emulator without requiring additional vim-scripts, see: https://www.youtube.com/watch?v=xZbMVj9XSUo

Fix #72

@styx
Copy link
Collaborator

styx commented Sep 11, 2016

@brodock thanks for the addition. At first you should update docs to get this merged.

Copy link
Collaborator

@styx styx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs for g:vroom_use_terminal

@brodock
Copy link
Contributor Author

brodock commented Sep 16, 2016

@styx I've added g:vroom_use_terminal documentation and made a few more fixes/improvements in the way NeoTerminal will open a split window and handle multiple execution of the same file:

  • It reuses the same split at current tab
  • As we can't re-use the terminal buffer, we have to close the old one and open a new
  • As terminal buffer name colide with the Regexp to identify if it's a spec file or not, additional checks are made to be sure current buffer is not NeoVim terminal
  • With changes above you can <leader>\r even when Terminal is focused and get expected results

@styx
Copy link
Collaborator

styx commented Sep 16, 2016

Looks good to me, just may be g:vroom_use_terminal should be g:vroom_use_nvim_terminal.
Let's wait for @skalnik, might be he want to take a look too.

@skalnik
Copy link
Owner

skalnik commented Sep 16, 2016

Seems reasonable to me! ❤️ 👍

I'm a bit indifferent about changing this to include nvim or neovim in the flag since normal vanilla Vim (vimilla?!) doesn't really have good terminal support. If it eventually does gain this, we can alter the settings as we need to.

@skalnik skalnik merged commit a92fc7a into skalnik:master Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants