Add option for disabling tag grouping #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -289,6 +298,19 @@ def create_tag_groups(tags: Set[Tag]): | |||
| groups.append(cjk_group) | |||
| return groups | |||
|
|
|||
| @staticmethod | |||
| def _create_tag_groups_disabled(tags: Set[Tag]): | |||
There was a problem hiding this comment.
This creates one "group" for each tag, which effectively results in each tag using one row. From my experience most people tend to add more tags rather than less, so they end up with lots of them (there are cases with more than a thousand tags). As a default, I think it makes more sense to display tags as inline elements from left to right, and then let them break into new lines when necessary. If your intention was to have one tag per row, you should still be able to make that work with custom CSS.
vslinko
force-pushed
the
tag-grouping-settings
branch
from
f6bafe4
to
99272af
Compare
sissbruecker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.