Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display shared state in bookmark list #515

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

sissbruecker
Copy link
Owner

@sissbruecker sissbruecker commented Aug 24, 2023

Adds a button to the bookmark actions that shows the shared state of the bookmark. Clicking the button brings up a confirmation to unshare the bookmark. For consistency, the mark as read button also has been changed to instead show the state ("Unread"), rather than the action. Clicking that button also brings up a confirmation to mark the bookmark as read.

Bildschirmfoto 2023-08-24 um 18 58 59

Closes #484

@sissbruecker sissbruecker merged commit 2ceac9a into master Aug 24, 2023
2 checks passed
@sissbruecker sissbruecker deleted the feat/display-share-state branch August 24, 2023 17:11
@gingerbeardman
Copy link
Contributor

gingerbeardman commented Aug 24, 2023

Awesome, thank you! I'll wait for the next version to hit docker as mine auto update.

@sissbruecker
Copy link
Owner Author

Still want to experiment with some other stuff before the next release. This PR also adds the shared class to bookmark list items if you want to tinker with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanded support for shared flag
2 participants