New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no duplication of imported tags (#287) #289

Merged

sissbruecker merged 3 commits into sissbruecker:master from wahlm:patch-287

Jul 3, 2022

Contributor

wahlm commented Jun 28, 2022 •

edited

Loading

Solves #287
Yes, the solution you proposed is just simpler and better. In addition I wrote a test to verify the solution.

wahlm and others added 3 commits

June 28, 2022 19:06


          no duplication of imported tags (sissbruecker#287)

c75b4da


          Add importer test

8fb081d


          Revert settings test

f4f4c94

Owner

sissbruecker commented Jul 3, 2022

Thanks, replaced the test with a more appropriate one.

sissbruecker merged commit 0829d00 into sissbruecker:master

sissbruecker mentioned this pull request

Duplicated and empty tags on import #287

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet