-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scraped title and description editable #80
Comments
I like the idea.
|
* Allow editing scraped title + description (#80) * Fix edit button hijacking form submit
I also like the idea, however the concept is that the input must be empty if you want to use the scraped values, so prefilling the inputs was not appropriate and would make it more difficult to replace it with a custom value, which is the more important use-case. I gave it a try to preselect the text when focussing the input, but that was too finicky. When clicking into the input the browser might start a text selection when moving the mouse / cursor at the same time. That in turn leads to a half selected text which is again problematic if you just want to quickly enter a custom value. As an alternative I implemented buttons that allow you to copy the scraped values into the input. That is a bit more inconvenient for this use-case, but I find it a reasonable trade-off. |
The grayed scraped entries should be editable at "new bookmark" dialog.
The text was updated successfully, but these errors were encountered: