Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scraped title and description editable #80

Closed
tanrak opened this issue Feb 18, 2021 · 3 comments · Fixed by #103
Closed

Make scraped title and description editable #80

tanrak opened this issue Feb 18, 2021 · 3 comments · Fixed by #103
Labels
enhancement New feature or request

Comments

@tanrak
Copy link

tanrak commented Feb 18, 2021

The grayed scraped entries should be editable at "new bookmark" dialog.

@Export33
Copy link

I like the idea.
Let the text greyed out while not entering a field to suggest an auto input.
When focussed select the whole scraped text. You could easily

  • overwrite the whole text with an single input because the text is selected
  • click into the text and change a certain area
  • if theres any text inserted by the user before the scraping is done use the inserted text (as it is right now)

sissbruecker added a commit that referenced this issue Apr 4, 2021
* Allow editing scraped title + description (#80)

* Fix edit button hijacking form submit
@sissbruecker sissbruecker added the enhancement New feature or request label Apr 4, 2021
@sissbruecker
Copy link
Owner

I also like the idea, however the concept is that the input must be empty if you want to use the scraped values, so prefilling the inputs was not appropriate and would make it more difficult to replace it with a custom value, which is the more important use-case.

I gave it a try to preselect the text when focussing the input, but that was too finicky. When clicking into the input the browser might start a text selection when moving the mouse / cursor at the same time. That in turn leads to a half selected text which is again problematic if you just want to quickly enter a custom value.

As an alternative I implemented buttons that allow you to copy the scraped values into the input. That is a bit more inconvenient for this use-case, but I find it a reasonable trade-off.

@Export33
Copy link

Export33 commented Apr 4, 2021

Using a button is totally ok. It is easily done and works fine for my few tests.

But i think the line-weight of the button itself does not fit to the overall ui-design because it´s too thick. Replacing it with a thinner icon or just a character would look better.

Example <:

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants