Avoid having a big big file #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge this until I figure it out how to to test it. |
shuLhan
requested changes
Sep 16, 2017
convert.go
Outdated
| if c.Debug || c.Dev { | ||
| err = writeDebug(bfd, c, toc) | ||
| if c.Split { | ||
| return translateToDir(c, toc, wd) | ||
| } else { |
There was a problem hiding this comment.
Ok, i know cause the return.
convert_to_dir.go
Outdated
|
|
||
| func generateCommonFile(c *Config, toc []Asset) error { | ||
| // Create output file. | ||
| fd, err := os.Create(filepath.Join(c.Output, "common.go")) |
There was a problem hiding this comment.
I prefer to use bindata.go as the common file, to minimize conflict if user want to generate to directory that has the common.go (since -split now assume output as dir, user can not change the output file name.)
There was a problem hiding this comment.
ok, u're right, it's better.
shuLhan
approved these changes
Sep 18, 2017
|
Thank you @ZaniaDeveloper @corebreaker . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up issue #13.
Add
-splitoption to avoid generating big file.