Skip to content

Commit

Permalink
[ZEPPELIN-3847] Duplicate results in notebooks due to WS interruption
Browse files Browse the repository at this point in the history
### What is this PR for?
Duplicate results in notebooks after ws reconnect.
The problem occurs via duplicated 'setConnectedStatus' event handler in notebook.controller.js.
The same function exists at https://github.com/Leemoonsoo/zeppelin/blob/dbbf0436490941d117fd4c06b9da5b6cb47697ff/zeppelin-web/src/app/notebook/notebook.controller.js#L99-L104.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3847

### How should this be tested?
Disconnect and reconnect websocket connection to browser, and check if result is duplicated.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <[email protected]>

Closes apache#3230 from Leemoonsoo/ZEPPELIN-3847 and squashes the following commits:

dbbf043 [Lee moon soo] remove duplicated setConnectedStatus event handler
  • Loading branch information
Leemoonsoo committed Nov 18, 2018
1 parent b31f299 commit 6e97a52
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions zeppelin-web/src/app/notebook/notebook.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -1361,13 +1361,6 @@ function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope,
$scope.$broadcast('focusParagraph', paragraph.id, row + 1, col);
};

$scope.$on('setConnectedStatus', function(event, param) {
if (connectedOnce && param) {
initNotebook();
}
connectedOnce = true;
});

$scope.$on('moveParagraphUp', function(event, paragraph) {
let newIndex = -1;
for (let i = 0; i < $scope.note.paragraphs.length; i++) {
Expand Down

0 comments on commit 6e97a52

Please sign in to comment.