Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HashMap and HashSet #54

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Implement HashMap and HashSet #54

merged 8 commits into from
Jan 2, 2024

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Dec 31, 2023

No description provided.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 1, 2024

(fzyzcjy/flutter_rust_bridge#1565 is waiting for this PR and release)

Copy link
Owner

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few comments, just needs adding few comments/doc-comments so people knows the expected behabviur.

src/into_dart.rs Outdated Show resolved Hide resolved
src/into_dart.rs Outdated Show resolved Hide resolved
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 2, 2024

done!

Copy link
Owner

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Thank you

@shekohex shekohex merged commit 395589a into shekohex:master Jan 2, 2024
5 checks passed
@shekohex
Copy link
Owner

shekohex commented Jan 2, 2024

Released in v0.1.22

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Jan 2, 2024

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants