-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/UUID #30
Feat/UUID #30
Conversation
Vec<u8> can be converted to Uint8List instead of List<T>, which is notoriously better for performance
Leaving link to experiment in the playground as a reminder, mostly to myself ^^ |
Also, something I'm not familiar in FFI / Rust / Dart contexts is if endianness matters or if this is already taken care of. So, should I explicitly settle on |
What is interesting is that we can also "pack" a
|
I could also adjust to the system, using Endianness on Dart side and cpu_endian on Rust side, what do you think ? |
I do think it does not matter that much, you better stick with just one on both sides, the other option is use the native endianness (in rust you use |
I made a quick bench locally to check whether there's a big delta in performance when using native endianness and it doesn't seem to make any notable difference (~2%). I cannot test on different machines with different endianness so I guess you're right, it can probably be ignored. |
I think it's ready for review 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There will be a bit of delay to publish this version now on crates.io since I'm on Mobile right now, but once I've my laptop I will issue a new release. Thank you! |
Thanks Shady, no worries ! |
In the same fashion, this PR adds support for uuid crate, since it's widely used in app and web alike.
I'm gonna keep as Draft until it's implemented downstream on
flutter_rust_bridge
(please hold on for a while, previous PR forchrono
types is almost finished but not quite yet).