-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update filtetypes #78
Conversation
* Reorder core filetypes as displayed by: `dircolors --print-database` * Add new core filetypes: * reset_to_normal * multi_hard_link * door * setuid * setgid See-Also: sharkdp#39
Thank you very much! Did you run some (manual) tests to make sure that the output still looks the same for all themes (on old filetypes)? |
Only for the gruvbox :D But I've created a small scripts to test, and that revealed some problems:
UPDATE: I've used wrong theme files that lead me to believe I've messed existing themes. In fact it's all good :D |
nice! We could even pipe the output of |
@sharkdp updated the script to allow me run diffing: for theme in \
ayu \
iceberg-dark \
jellybeans \
lava \
molokai \
nord \
one-dark \
one-light \
snazzy \
solarized-dark \
solarized-light
do
echo "*** ${theme}"
./test-theme ../vivid-master/config/filetypes.yml "../vivid-master/themes/${theme}.yml" > "old-${theme}"
./test-theme ./config/filetypes.yml "./themes/${theme}.yml" > "new-${theme}"
diff --color "old-${theme}" "new-${theme}"
rm -f "old-${theme}" "new-${theme}"
done And, seems like there are some bits to fix :D |
Oh. I get it now:
|
This comment has been minimized.
This comment has been minimized.
Prepending generated LS_COLORS with reset all: LS_COLORS="no=0:fi=0:rs=0:di=0:ln=0:mh=0:pi=0:so=0:do=0:bd=0:cd=0:or=0:mi=0:su=0:sg=0:ca=0:tw=0:ow=0:st=0:ex=0:${LS_COLORS}" Shows there will be no difference in most themes. Those with difference (as per diff command) don't look different to my eye. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for looking into it again!
dircolors --print-database
Closes: #39