Merge pull request #43 from mahlberg/server-interceptor

Fix return type from intercept_service
shabbyrobe · Sep 29, 2023 · 41edee8 · 41edee8
2 parents af6addc + 08faba1
commit 41edee8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/grpc-stubs/__init__.pyi b/grpc-stubs/__init__.pyi
@@ -616,7 +616,7 @@ class ServerInterceptor(typing.Generic[TRequest, TResponse]):
             typing.Optional[RpcMethodHandler[TRequest, TResponse]]
         ],
         handler_call_details: HandlerCallDetails,
-    ) -> RpcMethodHandler[TRequest, TResponse]:
+    ) -> typing.Optional[RpcMethodHandler[TRequest, TResponse]]:
         ...
 
 

diff --git a/typesafety/test_grpc.yml b/typesafety/test_grpc.yml
@@ -214,3 +214,15 @@
     server = typing.cast(aio.Server, None)
     enable_server_reflection(["foo"], server, None)
 
+- case: server_interceptor
+  main: |
+    import typing
+    import grpc
+    
+    class NoopInterceptor(grpc.ServerInterceptor):
+        def intercept_service(
+            self,
+            continuation: typing.Callable[[grpc.HandlerCallDetails], typing.Optional[grpc.RpcMethodHandler]],
+            handler_call_details: grpc.HandlerCallDetails,
+        ) -> typing.Optional[grpc.RpcMethodHandler]:
+            return continuation(handler_call_details)