This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Add missing TCPRouteList #34

Merged

michelleN merged 1 commit into servicemeshinterface:master from dtomcej:issue-33

Dec 11, 2019

Contributor

dtomcej commented Dec 11, 2019

This PR:

Adds missing TCPRouteList to scheme registration

The Informer in #33 requires a lister and a watcher. The lister returned TCPRouteList, which was not recognized, and the informer failed to sync.

Fixes #33


          add missing TCPRouteList

d44dba2

dtomcej mentioned this pull request

Use Listers instead of API Queries traefik/mesh#375

Merged

michelleN approved these changes

View reviewed changes

michelleN commented Dec 11, 2019

This is great! Thank you @dtomcej
As a follow up, we'll probably need to figure out what the testing strategy here should be.

michelleN merged commit 4e51d4d into servicemeshinterface:master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet