This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
prepare Makefile for release #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #22 |
grampelberg
reviewed
Sep 6, 2019
Makefile
Outdated
|
|
||
| .PHONY: dist | ||
| dist: | ||
| ( \ |
There was a problem hiding this comment.
Why is this a subshell?
There was a problem hiding this comment.
Needs to be otherwise the bash script won't work correctly. Did you notice that DIST_DIRS gets calculated with the find command in this line? Dunno if that makes it clearer. I could also move this script to its own file and run it from this make target but that seems unnecessary. Open to suggestions!
|
|
||
| .PHONY: build | ||
| build: | ||
| GOBIN=$(BINDIR) $(GO) install $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' github.com/deislabs/smi-sdk-go/cmd/installer |
There was a problem hiding this comment.
As a general style, I like separating these lines so they wrap at 80 chars (because I'm old).
* add following targets: build, build-cross, checksum, dist, bootstrap, test
grampelberg
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checksum, dist, bootstrap, test