Fix database file path location parser #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, thank you! |
|
I was trying to fix this (bug still in release), but couldn't reproduce while compiling from source. Now I understand why. Thank you! |
|
Ill roll a new release later today. |
|
Landed in 2.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered an issue in how absolute file paths are handled that are passed to the -D, --db-location flag.
Bug 🐛
https://github.com/sensepost/gowitness/blob/master/storage/db.go#L52 is missing logic to appropriately handle absolute file paths, for example:
'sqlite:///tmp/testing/gowitness.sqlite3'returns an empty string after being parsed via url.Parse() when calling the .Host method.Expected Functionality
Ability to specify absolute file paths to the -D, --db-location argument.
Solution
I've implemented a helper function that fixes the issue and added some unit tests for verification.
Passing Tests
Tested it with two trial runs that garnered the desired functionality.
Test cases are passing:
Issue Representation Example Code
Here's an example demonstrating the issue: GoPlayground
Lemme know if this PR requires adjustments. 🍻