Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve form invalid check logic #297

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Improve form invalid check logic #297

merged 4 commits into from
Jul 4, 2024

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Jul 4, 2024 •
edited
Loading

SendBird.-.Calendar.-.Week.of.June.30.2024.webm

https://sendbird.slack.com/archives/C0772Q0BB8Q/p1719970472144119

@liamcho liamcho added the 1.7.2 label Jul 4, 2024
@liamcho liamcho requested review from AhyoungRyu and bang9 July 4, 2024 02:31
@liamcho liamcho self-assigned this Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Size Change: +127 B (+0.02%)

Total Size: 617 kB

Filename Size Change
./dist/__bundle-2aa1a987-********.js 2.63 kB -1 B (-0.04%)
./dist/__bundle-347d730c-********.js 4.01 kB -1 B (-0.02%)
./dist/index-********.js 311 kB +82 B (+0.03%)
./dist/index.es.js 170 B -1 B (-0.58%)
./dist/index.umd.js 290 kB +48 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-b19a958d-********.js 891 B
./dist/style.css 7.95 kB

compressed-size-action

AhyoungRyu
AhyoungRyu reviewed Jul 4, 2024
View reviewed changes
src/components/messages/FormMessage.tsx Outdated Show resolved Hide resolved
src/components/FormInput.tsx Outdated Show resolved Hide resolved
@liamcho liamcho requested a review from AhyoungRyu July 4, 2024 03:22
@liamcho liamcho merged commit 73a3ec4 into develop Jul 4, 2024
5 checks passed
@liamcho liamcho deleted the feat/CLNP-3932-form-v2-improve-invalid-check-logic branch July 4, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhyoungRyu AhyoungRyu AhyoungRyu approved these changes

@bang9 bang9 Awaiting requested review from bang9

Assignees

@liamcho liamcho

Labels
1.7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamcho @AhyoungRyu