Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snowboy gstreamer plugin for gstreamer 1.14.1 #10

Merged
merged 3 commits into from
May 3, 2021

Conversation

liamw9534
Copy link

I am not sure if this repo is being actively maintained any longer. Nonetheless, I submit this PR out of courtesy as I am using the snowboy detector in my own project and thought it might be beneficial to others.

Copy link
Collaborator

@chenguoguo chenguoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, love it! I just had some comments on the style but once we fix that I can merge it.

This is very helpful to the community.

README.md Show resolved Hide resolved
Minor code style changes to plugin code.
Use sym link to main snowboy header file.
@liamw9534
Copy link
Author

Hope those changes are ok. All the best, Liam.

Copy link
Collaborator

@chenguoguo chenguoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging.

@chenguoguo chenguoguo merged commit e69b1fa into seasalt-ai:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants