Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DeveloperCheck to OrganizationMiddleware #28

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Updated DeveloperCheck to OrganizationMiddleware #28

merged 1 commit into from
Nov 1, 2020

Conversation

Braunson
Copy link
Contributor

@Braunson Braunson commented Nov 1, 2020

As per #20

adrijshikhar
adrijshikhar requested changes Nov 1, 2020
View reviewed changes
Copy link
Collaborator

@adrijshikhar adrijshikhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🎉.
As much as I appreciate it, I would also like you to add a class named OrganizationMiddleware in the Middleware folder to complete this flow.

@adrijshikhar adrijshikhar linked an issue Nov 1, 2020 that may be closed by this pull request
Rename DeveloperCheck Middleware to Organization middleware. #20
Closed
@Braunson
Copy link
Contributor Author

Braunson commented Nov 1, 2020

@adrijshikhar Perhaps I misunderstood. I converted the DeveloperCheck to OrganizationMiddleware already in the PR? Did you want to keep both classes for legacy purposes?

@adrijshikhar
Copy link
Collaborator

LGTM

@adrijshikhar adrijshikhar merged commit a6d9df3 into sdslabs:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrijshikhar adrijshikhar Awaiting requested review from adrijshikhar

Assignees
No one assigned
Labels
Hacktoberfest Hacktoberfest 2020 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename DeveloperCheck Middleware to Organization middleware.
2 participants
@Braunson @adrijshikhar