Skip to content

Commit

Permalink
Bugfixes
Browse files Browse the repository at this point in the history
  • Loading branch information
arpitsingla96 committed Oct 27, 2017
1 parent a1fbc18 commit 9305ad4
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 8 deletions.
16 changes: 12 additions & 4 deletions src/App/Http/Controllers/UserController.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace SDSLabs\Quark\App\Http\Controllers;

use SDSLabs\Quark\App\Models\User;
use SDSLabs\Quark\App\Models\Role;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
Expand All @@ -18,7 +17,7 @@ public function __construct(User $users)
{
$this->users = $users;
$this->middleware('auth')->except(['index', 'show', 'store']);
$this->middleware('falcon_auth')->only('store', 'showFalconMe');
$this->middleware('falcon_auth')->only(['store', 'showFalconMe']);
}

/**
Expand All @@ -39,15 +38,24 @@ public function index()
* @param \Illuminate\Http\Request $request
* @return \Illuminate\Http\Response
*/
public function store()
public function store(Request $request)
{
if (!is_null(Auth::user())) {
abort(409, "Already logged in.");
}

$this->validate($request, [
'username' => 'bail|required|alpha_dash|between:3,30|unique:users,username',
'fullname' => 'bail|required|regex:/^[\pL\s\-]+$/u|between:3,30',
'image' => 'bail|mimes:jpeg,jpg,png,gif|max:5120',
]);

$user = App::make(User::class, [$request->all()]);
// No idea why it doesn't work!
// $user = App::make(User::class, [$request->all()]);

$user = App::make(User::class);
$user->username = $request->username;
$user->fullname = $request->fullname;
$user->user_id = Auth::falconUser()['id'];
$user->email = Auth::falconUser()['email'];
$user->provider = 'falcon';
Expand Down
4 changes: 2 additions & 2 deletions src/App/Http/Middleware/FalconAuthenticate.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ public function __construct(Auth $auth)
*/
public function handle($request, Closure $next, $guard = 'falcon')
{
if (is_null($this->auth->guard($guard)->falconUser())) {
abort(401, "Authentication required");
if ($this->auth->guard($guard)->falconUser() === false) {
abort(401, "Falcon Authentication required");
}

return $next($request);
Expand Down
2 changes: 1 addition & 1 deletion src/App/Http/routes.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
Route::get('users/me/falcon', 'UserController@showFalconMe')->name('users.me.falcon.show');

// User routes
Route::resource('users', 'UserController', ['except' => ['destroy', 'create', 'store']]);
Route::resource('users', 'UserController', ['except' => ['destroy', 'create']]);

// Invite routes
Route::post('competitions/{competition}/teams/{team}/invite/{user}', 'CompetitionInvitesController@inviteUser')->name('invites.send');
Expand Down
3 changes: 2 additions & 1 deletion src/QuarkServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use SDSLabs\Quark\App\Auth\FalconGuard;
use SDSLabs\Quark\App\Http\Middleware\Authenticate;
use SDSLabs\Quark\App\Http\Middleware\FalconAuthenticate;
use SDSLabs\Quark\App\Http\Middleware\SubstituteBindings;
use SDSLabs\Quark\App\Http\Middleware\Developer;

Expand Down Expand Up @@ -37,7 +38,7 @@ public function setupRoutes(Router $router)
$router->prependMiddlewareToGroup('web',SubstituteBindings::class);

$router->middleWare('auth', Authenticate::class);
$router->middleWare('falcon_auth', Authenticate::class);
$router->middleWare('falcon_auth', FalconAuthenticate::class);
$router->middleWare('developer', Developer::class);
$router->middleWare('developer_check', DeveloperCheck::class);
$router->group([
Expand Down
1 change: 1 addition & 0 deletions src/config/auth.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
"client_id" => env('FALCON_CLIENT_ID'),
"client_secret" => env('FALCON_CLIENT_SECRET'),
"url_authorize" => "",
"redirect_uri" => "",
"url_access_token" => env('FALCON_URL_ACCESS_TOKEN'),
"url_resource_owner_details" => env('FALCON_URL_RESOURCE_ONWER_DETAILS'),
"accounts_url" => env('FALCON_ACCOUNTS_URL'),
Expand Down

0 comments on commit 9305ad4

Please sign in to comment.