Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-lib): correct ModuleWithProviders #75

Conversation

LayZeeDK
Copy link
Contributor

@LayZeeDK LayZeeDK commented Dec 20, 2019

Correctly expose a ModuleWithProviders.
Fixes #52 and corrects #69

Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 02059cd into scullyio:master Dec 21, 2019
@LayZeeDK LayZeeDK deleted the LayZeeDK/bugfix/componentsmodule-modulewithprovider branch December 21, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ComponentsModule is importing HttpClientModule
3 participants