Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): remove scroll event after angular load in flash prevention #737

Merged
merged 3 commits into from
Jul 13, 2020
Merged

fix(lib): remove scroll event after angular load in flash prevention #737

merged 3 commits into from
Jul 13, 2020

Conversation

jorgeucano
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Sometimes when use the flash-prevention the scroll event continue working after run angular

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

SanderElias
SanderElias approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,,

@jorgeucano jorgeucano merged commit b09ae1e into main Jul 13, 2020
@jorgeucano jorgeucano deleted the fix/flash-prevention-scroll branch July 13, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderElias SanderElias SanderElias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeucano @SanderElias