Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monorepo): add option to flashPrevention so set other display type #617

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

When the flashPreventionPlugin is done, it sets the display type to inherit.

Issue Number: N/A

What is the new behavior?

the displayType is now an option, if you need something else as inherit you can now set this as an optional parameter.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

When fhasl prevention is done, it sets the type to 'inherit'. This pr adds an option to set it to
anything you need.

ISSUES CLOSED: #608
Copy link
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW I like it

@SanderElias SanderElias merged commit d9cc896 into master Jun 8, 2020
@SanderElias SanderElias deleted the sander/fixDisplaySettingOnFlashPrevention branch June 8, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants