-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/watch mode #59
Fix/watch mode #59
Conversation
get support for error message when scully kill the app
scully/scully.ts
Outdated
checkChangeAngular(options.path); | ||
restartStaticServer(); | ||
} else { | ||
const folder = join(scullyConfig.homeFolder, scullyConfig.distFolder); | ||
|
||
if (!existDistAngular(scullyConfig.homeFolder)) { | ||
process.exit(0); | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there a try here? proccess.exit doesn't usually fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will eliminate the try / catch ... the output works fine!
It is a test that I left unintentionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping me when you are back online
Where are we at on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix(scully): rewrite watch mode
change all from the watch mode for support the new config, and some hotfix.
Fix problem with gosth node process