feat (schematics): allow comments in angular.json file (Issue #480) #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
atao60
changed the title
atao60
changed the title
|
It seems this pr is stuck. May be because replacing pr #531 just after @SanderElias assigned the review of this last one to @jorgeucano. |
jorgeucano
reviewed
May 25, 2020
libs/scully-schematics/package.json
Outdated
| @@ -15,7 +15,9 @@ | |||
| "test": "tsc -p tsconfig.spec.json && jasmine src/**/*_spec.js", | |||
| "publish:patch": "tsc -p ./tsconfig.json && npm version patch && npm publish --access public", | |||
| "publish:minor": "tsc -p ./tsconfig.json && npm version minor && npm publish --access public", | |||
| "publish:major": "tsc -p ./tsconfig.json && npm version major && npm publish --access public" | |||
| "publish:major": "tsc -p ./tsconfig.json && npm version major && npm publish --access public", | |||
| "clean": "rimraf spec/**/*.js spec/**/*.d.ts spec/**/*.js.map src/**/*.js src/**/*.d.ts src/**/*.js.map", | |||
There was a problem hiding this comment.
It's just a dev convenience to get a clean state before each build on workstation. Not needed during CI Build.
Can be removed if you wish.
There was a problem hiding this comment.
please remove this and I will approve! thanks!
SanderElias
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #480
What is the new behavior?
Allow comments in angular.json file with Scully schematics
In fact allow json5 syntax as Angular itself.
Note. ATM json5 is allowed only with angular.json files. But it'd be very easy to extend it to any json file of your choice.
Does this PR introduce a breaking change?
Other information
This is a sequel of pr #531, as in the meantime the folder schematics/scully has been moved to libs/scully-schematics.